[WIP] Deserialization #3
Conversation
joaoantoniocardoso
force-pushed
the
add_simple_deserialization
branch
from
045bd81 to
e40fe6d
Compare
|
@joaoantoniocardoso can you rebase your work ? |
| @@ -5,7 +5,7 @@ use ping_rs::{common, PingMessagePack}; | |||
| fn test_simple_serialization() { | |||
| let general_request = | |||
| common_messages::GeneralRequest(common::GeneralRequestStruct { requested_id: 5 }); | |||
| let message = PingMessagePack::from(general_request); | |||
| let message = PingMessagePack::from(&general_request); | |||
There was a problem hiding this comment.
This appears unnecessary on the current version
|
|
||
| fn try_from(buffer: &Vec<u8>) -> Result<Self, Self::Error> { | ||
| // Parse start1 and start2 | ||
| if !((buffer[0] == b'B') && (buffer[1] == b'R')) { |
There was a problem hiding this comment.
we should have a function and variables to compare the header and save B and R.
|
|
||
| fn try_from(buffer: &Vec<u8>) -> Result<Self, Self::Error> { | ||
| // Parse start1 and start2 | ||
| if !((buffer[0] == b'B') && (buffer[1] == b'R')) { |
There was a problem hiding this comment.
We should have a generic deserializer that stores the state of the parser. If we receive B, than R, than 3 more bytes, until the message is complete.
| let data_type = field.typ.to_rust(); | ||
| let data_size = field.typ.to_size(); | ||
| let field_token = quote! { | ||
| #name: #data_type::from_le_bytes(payload[#b..#b + #data_size].try_into().expect("Wrong slice length")), |
There was a problem hiding this comment.
We can check the initial size with payload.len(), try_into and everything else will be unnecessary,
| let data_type = field.typ.to_rust(); | ||
| let data_size = field.typ.to_size(); | ||
| let field_token = quote! { | ||
| #name: #data_type::from_le_bytes(payload[#b..#b + #data_size].try_into().expect("Wrong slice length")), |
There was a problem hiding this comment.
We should do #b + #data_size before putting on the template for better readability of the generated code.
| // Get the package data | ||
| let payload_length = u16::from_le_bytes([buffer[2], buffer[3]]); | ||
| let message_id = u16::from_le_bytes([buffer[4], buffer[5]]); | ||
| let _src_device_id = buffer[6]; |
There was a problem hiding this comment.
We should think how to handle it in a better way, maybe returning two structures, one that encapsulate the message and another one for the header or everything else, maybe a complete message.
|
@joaoantoniocardoso any update on that ? |
patrickelectric
force-pushed
the
add_simple_deserialization
branch
from
e40fe6d to
81a9a98
Compare
No description provided.